[image_picker] Removes use of PHAsset on IOS 14+ #8190
+16
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WenHaozhan Hey there, thanks for updating this! I think this PR looks good, but I'm new to this package and I'd like to confirm with my co-workers. It's the holidays in the US, so I will likely loop back next week. I apologize for the delay |
loic-sharma
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #8020
Fixes issue flutter/flutter#90373
Currently on IOS 14+, images are picked using
PHPickerViewControllerwhich does not need photo permissions and also gets the full image metadata regardless ofrequestFullMetadata. However, it currently retrieves the metadata usingPHAssetwhich does require permission and causes the gallery opening twice issue. Another issue is that an error is thrown when permission is denied even if none are required.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.